Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: change zip library to fix garbled extract file under node 20 #707

Merged
merged 2 commits into from
Apr 9, 2024
Merged

fix: change zip library to fix garbled extract file under node 20 #707

merged 2 commits into from
Apr 9, 2024

Conversation

jackie-linz
Copy link
Contributor

fixes: #689

robinraju
robinraju approved these changes Apr 9, 2024
View reviewed changes
Copy link
Owner

@robinraju robinraju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jackie-linz Thank you for submitting this PR.

@robinraju robinraju merged commit 452eec1 into robinraju:main Apr 9, 2024
1 of 4 checks passed
robinraju added a commit that referenced this pull request Apr 9, 2024
@robinraju
Revert "fix: change zip library to fix garbled extract file under nod…
3c90321 
…e 20 (#707)"

This reverts commit 452eec1.
@jackie-linz
Copy link
Contributor Author

@robinraju no worries.

Sorry just realised I did not run package so the dist file was not updated. do you want me to raise another PR?

@jackie-linz jackie-linz mentioned this pull request Apr 9, 2024
Closed
@robinraju
Copy link
Owner

robinraju commented Apr 9, 2024 •
edited
Loading

@robinraju no worries.

Sorry just realised I did not run package so the dist file was not updated. do you want me to raise another PR?

@jackie-linz oops, I missed noticing it.
I also noticed, the test is failing on windows, after merging it. I'm trying to debug it. Most probably caused by the line endings when you read the text file.
Please open the PR for packaged js.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robinraju robinraju robinraju approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

1.9 version seems to have broken the extract functionality
2 participants
@jackie-linz @robinraju