Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rewrite: command structure clean-up #20

Merged
merged 3 commits into from
Aug 28, 2024

Conversation

LawMixer
Copy link
Member

No description provided.

@LawMixer LawMixer changed the title rewrite: Command Structure clean-up rewrite: command structure clean-up Jul 27, 2024
@LawMixer LawMixer requested a review from Hedwig7s August 28, 2024 11:56
@LawMixer LawMixer marked this pull request as ready for review August 28, 2024 11:56
@Hedwig7s
Copy link
Contributor

Hedwig7s commented Aug 28, 2024

Why is stdio.write being used over print? The only difference (at least in this situation) is stdio.write doesn't append a \n

@LawMixer
Copy link
Member Author

Print doesn't have rich text (example for the colors) - I'm just copying what was previously there;

@AsynchronousAI AsynchronousAI merged commit 4b27e8e into roblox-compilers:stable Aug 28, 2024
2 checks passed
@Hedwig7s
Copy link
Contributor

The original file had print and colors worked fine
I do not see the purpose of using stdio.write

@LawMixer
Copy link
Member Author

The original file had print and colors worked fine I do not see the purpose of using stdio.write

It writes directly to stdio/stdout without the auto formatting print/warn/error has which was causing further issues with me using the logging functions;

@AsynchronousAI
Copy link
Member

If you want to clean it use a for loop and table to hold the command name, descriptions, and color.

@LawMixer
Copy link
Member Author

I'll probably play around with somethings, just wanted to do release this so that we can keep moving on the development;

@AsynchronousAI
Copy link
Member

I'll probably play around with somethings, just wanted to do release this so that we can keep moving on the development;

No problem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants