Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use pkg-config #39

Merged
merged 1 commit into from
Oct 7, 2023
Merged

Use pkg-config #39

merged 1 commit into from
Oct 7, 2023

Conversation

robo9k
Copy link
Owner

@robo9k robo9k commented Oct 7, 2023

This implements #1 and should solve the long standing issues of linking on macOS and statically in general.

This is a (potentially) breaking change for several reasons:

Related issues:

Misc:

  • the new pkg-config crate dependency has a MSRV of v1.30.0, so we don't need to bump ours

Follow-up tasks: (not in this pull request)

Signed-off-by: robot9001 <robo9k@symlink.io>
@robo9k robo9k marked this pull request as ready for review October 7, 2023 16:58
@robo9k robo9k merged commit bbddb20 into main Oct 7, 2023
8 of 9 checks passed
@robo9k robo9k deleted the pkg-config branch October 7, 2023 16:58
@robo9k
Copy link
Owner Author

robo9k commented Oct 7, 2023

The MACIG_LINK=auto|dynamic|static env config in #35 (comment) is not actually easily possible (with vcpkg), thus it is not implemented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant