Skip to content

Commit

Permalink
Fix actions retrieval bug
Browse files Browse the repository at this point in the history
  • Loading branch information
cmin764 committed Oct 3, 2023
1 parent 954dcfb commit 850f335
Show file tree
Hide file tree
Showing 4 changed files with 11 additions and 10 deletions.
6 changes: 3 additions & 3 deletions poetry.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 5 additions & 5 deletions src/JABWrapper/context_tree.py
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ def children(self):
with self._lock:
return self._children

def _parse_context(self) -> None:
def parse_context(self) -> None:
logging.debug(f"Parsing element={self.context}")
self._aci: AccessibleContextInfo = self._jab_wrapper.get_context_info(self.context)
logging.debug(f"Parsed element info={self._aci}")
Expand Down Expand Up @@ -146,7 +146,7 @@ def refresh(self):
with self._lock:
self.state = None
self._children.clear()
self._parse_context()
self.parse_context()
if self._should_parse_children:
self._parse_children()

Expand Down Expand Up @@ -405,15 +405,15 @@ def _property_selection_change_cp(self, source: JavaObject) -> None:
with self._lock:
node: ContextNode = self.root._get_node_by_context(source)
if node:
node._parse_context()
node.parse_context()
logging.debug(f"Selected text changed for node={node}")

@retry_callback
def _property_text_change_cp(self, source: JavaObject) -> None:
with self._lock:
node: ContextNode = self.root._get_node_by_context(source)
if node:
node._parse_context()
node.parse_context()
logging.debug(f"Text changed for node={node}")

@retry_callback
Expand Down Expand Up @@ -522,7 +522,7 @@ def _register_callbacks(self) -> None:
are generated from the Access Bridge
"""
if self._jab_wrapper.ignore_callbacks:
logging.debug("Ignoring callback regitering for Context Node")
logging.debug("Ignoring callback registering for Context Node")
return

self._jab_wrapper.clear_callbacks()
Expand Down
2 changes: 1 addition & 1 deletion src/JABWrapper/parsers/actions_parser.py
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ def parse(self, jab_wrapper: JavaAccessBridgeWrapper, context: JavaObject) -> No
self._actions[actionInfo.name.lower()] = actionInfo

def list_actions(self) -> List[str]:
return self._actions.keys()
return list(self._actions)

def do_action(self, jab_wrapper: JavaAccessBridgeWrapper, context: JavaObject, action: str) -> None:
if not action.lower() in self._actions:
Expand Down
3 changes: 2 additions & 1 deletion tests/test_jab_wrapper.py
Original file line number Diff line number Diff line change
Expand Up @@ -308,7 +308,8 @@ def update_and_refresh_table(context_info_tree, *, jab_wrapper):
update_button = context_info_tree.get_by_attrs(
[SearchElement("role", "push button"), SearchElement("name", "Update")]
)[0]
logging.debug("Found 'Update' button: %s", update_button)
actions = update_button.get_actions()
logging.debug("Found 'Update' button %r with actions: %s", update_button, actions)
update_button.click()

expected_total_children = initial_children
Expand Down

0 comments on commit 850f335

Please sign in to comment.