Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial refactoring for standardizing linting and testing #15

Merged
merged 13 commits into from
Sep 21, 2023

Conversation

cmin764
Copy link
Contributor

@cmin764 cmin764 commented Sep 18, 2023

Dependency of #14

Adds a thin layer of not too opinionated formatting (from our configuration intervention/deviation PoV):

  • Linting: isort, black, flake8/pep8 (exception for the line length 88 -> 120 chars; TBD)
  • Beta 1.0.0 release with package updates included
  • Applies current rules into formatting through inv lint -a command

❗ By any means this doesn't and shouldn't change behaviour, it's only a cosmetic refactoring aided by Invoke through Poetry commands.

ToDo

  • Refactor the entire test with pytest. (and fixtures for the JAB wrapper and context tree)
  • Add build and publish (CI/prod) Invoke commands.
  • Add simple README section with:
    • How to quickly isolate the env preparation with pyenv. (so Poetry and Invoke are made available)
    • How to setup Poetry config and credentials. (for CI/prod package publishing)

Check updated README Development instructions

@cmin764 cmin764 added the refactor Changes structure and looks, but not behaviour label Sep 18, 2023
@cmin764 cmin764 self-assigned this Sep 18, 2023
config/flake8 Outdated Show resolved Hide resolved
config/flake8 Show resolved Hide resolved
Copy link
Collaborator

@mmokko mmokko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I'll add the pipeline and merge.

config/flake8 Show resolved Hide resolved
@mmokko mmokko merged commit e9bd5ef into master Sep 21, 2023
1 check passed
@mmokko mmokko deleted the refactor/linting-testing branch September 21, 2023 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Changes structure and looks, but not behaviour
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants