Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix problem with keyless access and Active Learning #214

Merged
merged 2 commits into from
Dec 29, 2023
Merged

Fix problem with keyless access and Active Learning #214

merged 2 commits into from
Dec 29, 2023

Conversation

PawelPeczek-Roboflow
Copy link
Collaborator

@PawelPeczek-Roboflow PawelPeczek-Roboflow commented Dec 29, 2023 •
edited
Loading

Description

  • Disable active learning each time api key is not used
  • Fix malformed payload in clip compare
  • Fix double invocation of AL registration in AL middleware

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

How has this change been tested, please provide a testcase or example of how you tested the change?

  • added new tests
  • CI still green

Any specific deployment considerations

For example, documentation changes, usability, usage/costs, secrets, etc.

Docs

  • Docs updated? What were the changes:

@PawelPeczek-Roboflow PawelPeczek-Roboflow marked this pull request as ready for review December 29, 2023 16:23
paulguerrie
paulguerrie approved these changes Dec 29, 2023
View reviewed changes
Copy link
Contributor

@paulguerrie paulguerrie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@PawelPeczek-Roboflow PawelPeczek-Roboflow merged commit 2faf2af into main Dec 29, 2023
4 checks passed
@PawelPeczek-Roboflow PawelPeczek-Roboflow deleted the fix/improve_keyless_models_handling branch December 29, 2023 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulguerrie paulguerrie paulguerrie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PawelPeczek-Roboflow @paulguerrie