-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PolygonZone: estimate how much of the zone is occupied #1449
Comments
Hi @stevensagaert, I'd like to help by submitting a PR |
Hi @Sapienscoding, I've assigned another issue to you. Let's go with one at a time. |
Hi @stevensagaert 👋 Apologies for the delay. If you're still keen, we'd be happy to include area occupation stats in our PolygonZone. |
Hi, it is my first time contributing to open source project and I would like to work on this issue. Please do guide me if possible. Thank you! |
Hi,
I'll make some time in 2 weeks or so. Right now I'm too busy at work.
…________________________________
From: LinasKo ***@***.***>
Sent: Tuesday, October 15, 2024 8:48 AM
To: roboflow/supervision ***@***.***>
Cc: Steven Sagaert ***@***.***>; Mention ***@***.***>
Subject: Re: [roboflow/supervision] PolygonZone: estimate how much of the zone is occupied (Issue #1449)
CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you recognize the sender and know the content is safe.
Hi @stevensagaert<https://github.com/stevensagaert> 👋
Apologies for the delay. If you're still keen, we'd be happy to include area occupation stats in our PolygonZone.
—
Reply to this email directly, view it on GitHub<#1449 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/A7A5SMGF3R5NLUEQ43D6KW3Z3S3CRAVCNFSM6AAAAABMQRAQWKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMJTGAZTCOJZGU>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
@stevensagaert Can I resolve this issue ? |
You mean you want to implement it or just close it? I haven't had time to do it yet. |
@stevensagaert I would like to try to implement it. |
Ok go ahead 🙂. The bulk of the functionality is in the 2 functions I put in this issue. The rest should be just glue code.
…________________________________
From: Archit H Barve ***@***.***>
Sent: Wednesday, October 30, 2024 10:01 AM
To: roboflow/supervision ***@***.***>
Cc: Steven Sagaert ***@***.***>; Mention ***@***.***>
Subject: Re: [roboflow/supervision] PolygonZone: estimate how much of the zone is occupied (Issue #1449)
CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you recognize the sender and know the content is safe.
@stevensagaert<https://github.com/stevensagaert> I would like to try to implement it.
—
Reply to this email directly, view it on GitHub<#1449 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/A7A5SMB2O7BWFMEBCJGIMHLZ6CN6XAVCNFSM6AAAAABMQRAQWKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINBWGI2DIMJVG4>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
Hi @AHB102 👋 Assigning this to you. Note that Detection can take one of 3 forms:
Ideally, this method should work regardless of detection type, but it's okay if it returns a slightly-approximated result. You may find the |
@LinasKo Thanks for the insight 😁, will get started on this. |
@LinasKo Hi 👋,I haven't written much code for this feature. I mostly used Steven's existing code, but I added checks for the detection cases based on your recommendations. Had some questions : |
Hi @AHB102 👋
|
Okay nice! Will definitely make the type hinting work, and can I commit the changes and make a PR ? |
Yes, absolutely. Typically contributors fork the repo, make the changes their version of it, on a branch such as |
@LinasKo I got a bit lost in the first PR. I believe this one is correct. Thanks for your patience😅 |
Thank you @AHB102! I'll have a look as soon as I can, likely next week. |
Search before asking
Description
Next to the count of the objects in the zone, it would be useful to know how much of the zone area is occupied by the objects.
Use case
e.g. for loading zones in warehouses
Additional
Basically I've implemented it myself outside of the PolygonZone class. The core of what is needed is these two functions:
strategy:
Are you willing to submit a PR?
The text was updated successfully, but these errors were encountered: