Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor InferenceSlicer overlap logic #1434

Merged
merged 11 commits into from
Aug 8, 2024
Merged

refactor InferenceSlicer overlap logic #1434

merged 11 commits into from
Aug 8, 2024

Conversation

SkalskiP
Copy link
Collaborator

@SkalskiP SkalskiP commented Aug 6, 2024 •
edited
Loading

Description

  • Deprecate the overlap_ratio_wh argument
  • Introduce the overlap_wh argument
  • Rename the overlap_filter_strategy argument to overlap_filter

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

Docs

  • Docs updated? What were the changes:

LinasKo
LinasKo requested changes Aug 6, 2024
View reviewed changes
supervision/detection/tools/inference_slicer.py Outdated Show resolved Hide resolved
supervision/detection/tools/inference_slicer.py Outdated Show resolved Hide resolved
supervision/detection/tools/inference_slicer.py Show resolved Hide resolved
@LinasKo
Copy link
Collaborator

LinasKo commented Aug 6, 2024

Looks good based on the code alone. Need some help with tests tomorrow?

@SkalskiP SkalskiP mentioned this pull request Aug 7, 2024
Closed
@SkalskiP
Copy link
Collaborator Author

SkalskiP commented Aug 7, 2024

@LinasKo here is my testing colab: https://colab.research.google.com/drive/1NC3MelyQVtiv7wt9E6U-hlqkqEzg-x5G?usp=sharing

LinasKo
LinasKo approved these changes Aug 7, 2024
View reviewed changes
Copy link
Collaborator

@LinasKo LinasKo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very tiny typos, but otherwise I see no issues. Approving preemptively.

supervision/detection/tools/inference_slicer.py Outdated Show resolved Hide resolved
supervision/detection/tools/inference_slicer.py Outdated Show resolved Hide resolved
@SkalskiP SkalskiP merged commit d486dd1 into develop Aug 8, 2024
9 checks passed
@ediardo ediardo mentioned this pull request Aug 27, 2024
Merged
4 tasks
@LinasKo LinasKo mentioned this pull request Aug 27, 2024
Merged
@onuralpszr onuralpszr deleted the feature/refactor_inference_slicer_overlap_definition branch September 23, 2024 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LinasKo LinasKo LinasKo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SkalskiP @LinasKo