[TriangleAnnotator, DotAnnotator] - allow customization of the contour color #1403 #1458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and dot annotator
Kadermiyanyedi
force-pushed
the
add-outline-color-to-triangle-and-dot-annotator
branch
from
8b2484c to
190fcba
Compare
Kadermiyanyedi
force-pushed
the
add-outline-color-to-triangle-and-dot-annotator
branch
from
190fcba to
10ea37b
Compare
* It would render the docs incorrectly
LinasKo
approved these changes
Aug 18, 2024
There was a problem hiding this comment.
Hi @Kadermiyanyedi 👋,
Thank you for clean, well-tested contribution! I've changed the docstring a tiny bit to so mkdocs can generate the docs correctly, but other than that I see no issues!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new outline_color argument to the TriangleAnnotator and DotAnnotator classes, allowing users to customize the outline color when rendering annotations. Previously, while users could set outline_thickness to render an outline, the color was not configurable. With this enhancement, outline_color can now be set and will integrate seamlessly with the existing color_lookup system, accepting values of type Union[Color, ColorPalette].
Key Changes
Added outline_color argument to TriangleAnnotator and DotAnnotator.
Integrated outline_color with the existing color_lookup mechanism.
resolve #1403
For testing purposes, please refer to the provided Colab link.
Please review thank you :)