Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate that polygon has at least 1 vertex in geometry utils.py #1602

Merged
merged 3 commits into from
Oct 17, 2024
Merged

Validate that polygon has at least 1 vertex in geometry utils.py #1602

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5ac3999
Validate that polygon has at least 3 vertices in geometry utils.py
ablazejuk Oct 17, 2024
f8ff332
fix(pre_commit): 🎨 auto format pre-commit hooks
pre-commit-ci[bot] Oct 17, 2024
1b95d1d
Change get_polygon_center validation to fail on 0 points
LinasKo Oct 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions supervision/geometry/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,9 @@ def get_polygon_center(polygon: np.ndarray) -> Point:
Point: The center of the polygon, represented as a
Point object with x and y attributes.

Raises:
ValueError: If the polygon has no vertices.

Examples:
```python
import numpy as np
Expand All @@ -30,6 +33,9 @@ def get_polygon_center(polygon: np.ndarray) -> Point:
# This is one of the 3 candidate algorithms considered for centroid calculation.
# For a more detailed discussion, see PR #1084 and commit eb33176

if len(polygon) == 0:
raise ValueError("Polygon must have at least one vertex.")

shift_polygon = np.roll(polygon, -1, axis=0)
signed_areas = np.cross(polygon, shift_polygon) / 2
if signed_areas.sum() == 0:
Expand Down