-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🛠️ fix incorrect COCO class id loading #176
Conversation
Hi, @hardikdava 👋🏻 did you have a chance to test this? |
@SkalskiP Let me test and confirm your fix. |
@SkalskiP Test summary: Case-1: Case-2: |
@hardikdava, as for case 2, do you think we would like |
@SkalskiP Yes, based on my research and description from coco, opencv, etc it is their standard format to start |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please make this small changes and we can close this.
@hardikdava, that should be easy. I'll update |
@hardikdava given the fact that @yclicc tested the code and it works as expected. (read more here #150) I'll probably close #169. Is it okey with you? |
@SkalskiP Yes, please mark it as completed. |
Description
Draft of PR fixing issues mentioned #150. It is an alternative to the #169 solution.