-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed TraceAnnotator to respect the postion argument. #511
Conversation
Linezonetrigger
change return type from list to nparray
@SkalskiP Please review this pr. |
Hi, @abhishek7kalra! 👋🏻 Thanks for your interest in Supervision and solving this issue. However, the solution for this bug is much simpler. The logic that you made is already part of All you have to do is pass `position here, and it should work.
|
Hi, @abhishek7kalra! 👋🏻 Unfortunately, I couldn't wait any longer for you to implement the fixes, so I decided to do it myself. Thanks a lot for your help! 🙏🏻 Merging! |
Hey @SkalskiP, thank you for going ahead with the fix. I got super busy, so couldn't do the implementation myself. 😅 |
Description
Added necessary logic in TraceAnnotator so that it now respects the position argument. The update now allows all the predefined positions which when passed to modify the tracing position.
Issue: #420
Type of change
Please delete options that are not relevant.
How has this change been tested, please provide a testcase or example of how you tested the change?
trace_annotator = sv.TraceAnnotator(position=Position.TOP_LEFT)
trace_topleft.mp4