-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[IconAnnotator] - Add IconAnnotator to Mark Objects with Custom Icons/Images #930
[IconAnnotator] - Add IconAnnotator to Mark Objects with Custom Icons/Images #930
Conversation
* Add test for icon annotator, with sample test files to verify
Hi @dfreilich 👋🏻 ! Thank you very much for your interest in Supervision.
|
* Update docs
* Simplify code to remove unnecessary comments * Make code style and sample code fit with other patterns in file * Raise exception if invalid icon
@SkalskiP Thanks for the review! I addressed the comments, and removed the unit tests I had created. With regards to the changes in acceptance.md, I assumed that it didn't make sense to add the supervision/docs/annotators.md Lines 8 to 27 in 8599345
media.roboflow.com , like the rest of the examples, but I can add one if you'd like.
|
I've modernized and cleaned up this one, but will shift focus for now. I'll be back after the metrics are complete. I believe one change is needed - instead of specifying an icon at the start, we could take a Here's my tests: Colab Steps afterwards:
|
b08e7f3
to
734ee3f
Compare
734ee3f
to
317485b
Compare
Hey @onuralpszr, Got a second to look at the code for this one, by any chance? 😉 |
With pleasure :) |
Thank you @dfreilich! I've edited your submission heavily, added slightly different functionality. Yet without your contribution we wouldn't have this :) Thank you for the review, @onuralpszr! |
Description
This PR adds an IconAnnotator class, which can annotate images. For best results, the icon should be a transparent icon without a background, so that it will come up clearly against any images.
Some open questions for discussion:
I'd love to hear your thoughts on it.
A Collab notebook which demonstrates the change is here
Type of change
Please delete options that are not relevant.
How has this change been tested, please provide a testcase or example of how you tested the change?
This change includes a unit test (the first created for annotations) to verify that the annotation works, and the result closely matches a so-called golden file
Docs
Closes #460