org.robolectric:shadows-supportv4 doesn't support Jetpack(androidx)

[XinyueZ]

Main repo: org.robolectric:robolectric:4.0-alpha-4-SNAPSHOT works with androidx
org.robolectric:shadows-supportv4 doesn't work, ie:

class TestSupportFragment extends androidx.fragment.app.Fragment

doesn't work -----> SupportFragmentController.of(new TestSupportFragment())

any snapshot for shadows-supportv4 ?

issue

[seadowg]

Seeing this as well. Using the new androidx Fragment class doesn't appear to work. Android Studio warns you that your Fragment is not a subtype of android.support.v4.app.Fragment and there is a no such method error when running a test:

java.lang.NoSuchMethodError: org.robolectric.shadows.support.v4.SupportFragmentController.of(Landroidx/fragment/app/Fragment;)Lorg/robolectric/shadows/support/v4/SupportFragmentController;

[seadowg]

Interestingly if I run tests through Gradle directly (and not through Android Studio) they are fine. Could this be a problem with Jetifier?

[XinyueZ]

If you don't edit the whole project which means all package names of android.support.fragment to the androidx.app.fragment.
Try to edit the whole project with the androidx namespace and dependencies of fragment, you will see the problem @seadowg

[sdetilly]

Any news on this? Some of my tests are failing because of the "NoSuchMethodError" problem

[XinyueZ]

@sdetilly Actually I have done it by myself, here is one example:
https://github.com/XinyueZ/easypermissions/blob/feature/androidx/easypermissions/src/test/java/pub/devrel/easypermissions/SupportFragmentController.java

[userdimi]

Have the same issue. I can't create a andoidx.fragment.app Fragment with Robolectric

[jongerrish]

We actually have a replacement for Support FragmentController coming out soon.

…

On Mon, Oct 22, 2018, 9:50 AM Dimitri Simon ***@***.*** wrote: Have the same issue. I can't create a andoidx.fragment.app Fragment with Robolectric — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#3985 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AGBaeA_RJ9z6jlgugoLsUWHWUU6Q3p2Oks5unXingaJpZM4WTSVl> .

[chriscoomber]

@jongerrish any update on this? Or known workarounds? We've not been able to run any of our Fragment tests in Android studio because of this (but for some reason, as mentioned above, they still work on the command line).

[jongerrish]

We have a new API for Fragments which should launch Monday and is compatible both for Instrumentation tests and local tests in Robolectric.

[Sai-Deepthi]

@jongerrish any particular release date for it?

[jongerrish]

@Sai-Deepthi It was released this week.

More details here:- https://developer.android.com/training/basics/fragments/testing

[NickButcher1]

The new FragmentScenario library won't help with org.robolectric.shadows.support.v4.ShadowLocalBroadcastManager will it? Won't I still need the shadows-supportv4 dependency if I want to use ShadowLocalBroadcastManager?

[jongerrish]

See the comment on #2849 """ LocalBroadcastReceiver doesn't really need a shadow, tests could instead be written to simply register a receiver that checks for broadcasts being sent. """ Is this a major issue for you? We'd prefer to delete that shadow, but we don't want to make life difficult for you so if its a problem we can look at producing an androidx version of the whole library.

…

On Tue, 13 Nov 2018 at 10:47, Nick Butcher ***@***.***> wrote: The new FragmentScenario library won't help with org.robolectric.shadows.support.v4.ShadowLocalBroadcastManager will it? Won't I still need the shadows-supportv4 dependency if I want to use ShadowLocalBroadcastManager? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#3985 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AGBaeGUXYIkGMFwekmvk44WlFjWXsW1lks5uuxOtgaJpZM4WTSVl> .

[NickButcher1]

I'm happy to try and remove my need for ShadowLocalBroadcastManager by following the advice in #2849. Thanks!

[jongerrish]

Cool, Please let us know if it causes you any problems. We've never marked it @deprecated so we should support this migration for you, but I'd be interested in your experience following the advice. It would be useful for us to document the migration case for when we do deprecate it.

…

On Tue, 13 Nov 2018 at 11:13, Nick Butcher ***@***.***> wrote: I'm happy to try and remove my need for ShadowLocalBroadcastManager by following the advice in #2849 <#2849>. Thanks! — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#3985 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AGBaeIUxWk26o_q7-W_y6lRgRjaj2rHnks5uuxnmgaJpZM4WTSVl> .

[NickButcher1]

No problems. I fixed my tests, as suggested, to register a LocalBroadcastReceiver which checks that the Intents that it receives match what the test cases are expecting.

[gefilte]

Definitely would have been a smoother transition to AndroidX if this worked... right now I've had to mark some tests as @ignore until I can rewrite them. They all use startFragment which oddly enough compiles despite the linter warning, but fails to run since the method signatures are looking for support library Fragment and Activity classes, but I've got AndroidX variants.

[luongvo]

@XinyueZ @seadowg @sdetilly @userdimi I met this issue too, so I just created this clones: https://github.com/nimbl3/robolectric.shadows-supportv4, it helps support current tests using robolectric:shadows-supportv4 works without any changes in test codes. Maybe it could help you while waiting for official support from robolectric team 🚀

Example here: https://github.com/nimbl3/robolectric.shadows-supportv4/blob/master/app/src/test/java/co/nimblehq/robolectric/shadows/supportv4/TestFragmentTest.kt

[KevinLeigh]

Hey @XinyueZ @seadowg @sdetilly @userdimi,

You can use FragmentScenario from package -> androidx.fragment:fragment-testing

See Official doc: https://developer.android.com/training/basics/fragments/testing

[sdetilly]

@luongvo Thank you very much for the library! it helps alot! @KevinLeigh I think i will wait until androidx.fragment:fragment-testing is out of alpha before integrating in my production app. I am worried that it can introduce bugs

[msawan-resilient]

Hi all,

Any update on this issue?

[utzcoz]

The Robolectric has removed shadows for v4 from 4.9. So I will close this issue. Feel free to reopen this issue if you have similar issues when running the latest Robolectric with AndroidX.

[seadowg]

@utzcoz is there any plan to provide Shadows for other (that Fragment) AndroidX component like AlertDialog? I'd be interested to know if the thinking is that people should create their own custom ones, or if there's a hope that Shadows can be avoided as the AndroidX APIs play nicer with tests? The latter seems to be a direction we're heading in.

[utzcoz]

is there any plan to provide Shadows for other (that Fragment) AndroidX component like AlertDialog

I think not, at least from my part. The Robolectric focus on the main components of AOSP's frameworks, and AndroidX components are separate. If these components rely on AOSP's components, I think we can improve the shadow of the AOSP's one to fix issues for these AndroidX components. If not, users/developers can maintain the custom shadow for these components if needed. @hoisie What do you think?

[brettchabot]

androidx libraries should not require shadows. If you find an androidx API that isn't testable I'd recommend filing an issue against androidx.