Skip to content

Commit

Permalink
Revert filtering on repositories to be updated (#1412)
Browse files Browse the repository at this point in the history
This reverts a part of #1383 so that repository updates are done in the pre-0.125.0 way, which tries to update any repositories only once regardless of they are referenced by selected releases or not.

Ref #1404
  • Loading branch information
mumoshu authored Aug 13, 2020
1 parent ab1c118 commit ec87a39
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 6 deletions.
1 change: 1 addition & 0 deletions pkg/app/app_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -2490,6 +2490,7 @@ releases:

var wantRepos = []mockRepo{
{Name: "stable"},
{Name: "stable2"},
}

var buffer bytes.Buffer
Expand Down
7 changes: 1 addition & 6 deletions pkg/state/state.go
Original file line number Diff line number Diff line change
Expand Up @@ -330,15 +330,10 @@ func (st *HelmState) getRepositoriesToSync() (map[string]bool, error) {
}

func (st *HelmState) SyncRepos(helm RepoUpdater, shouldSkip map[string]bool) ([]string, error) {
shouldUpdate, err := st.getRepositoriesToSync()
if err != nil {
return nil, err
}

var updated []string

for _, repo := range st.Repositories {
if !shouldUpdate[repo.Name] || shouldSkip[repo.Name] {
if shouldSkip[repo.Name] {
continue
}

Expand Down

0 comments on commit ec87a39

Please sign in to comment.