-
Notifications
You must be signed in to change notification settings - Fork 564
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Install a directory of K8s manifests as a chart does not work #1413
Comments
@pandvan Thank you so much for reporting! This was indeed a regression since 0.125.6 and I'm fixing it shortly via helmfile/chartify@dba403c and #1417. |
Is this issue up again? I'm hitting this with 0.137.0. if the chart is part of the folder where the helmfile is, then the issue occurs. If it's in a different folder, it doesn't. Example:
UPD: It turns out that the problem occurs if there is no UPD: It might actually be a bug. Maybe worth looking into it. From what I see in the code, there is a library used that can bootstrap a |
@vasrem Thanks for reporting. Just curious, but did the same configuration work for previous version(s) of helmfile? |
@mumoshu apologies from my side for the long delay. Did some tests to find when the regression happened based on minor versions (didn't consider patches):
It seems that there is a change in the type of error between 0.125 and 0.126. Let me know if there is something I could help with. |
@vasrem Hey! Thanks for the reply. I'm wondering if the content of your manifests is also contributing to the error. Would you mind sharing me your manifests (or a smaller subset of it) for reproduction if possible? |
Also, could you confirm that you did specify |
I confirm that I specified this in all the tests I've done and the output of them can be found here #1413 (comment).
That sounds great!
It's pretty simple to reproduce. Please use the structure mentioned above in #1413 (comment) with the following content.
By doing the following command, you can reproduce:
|
@vasrem Hey! Thanks for confirmations and the additional info. Your Probably you had similar go template expression (that looks like Are you trying to render some YAML file as a Helmfile template and turning it into a temporary chart? |
This was failing between from
The file As I mentioned above #1413 (comment):
if the chart doesn't contain a
|
@vasrem Unfortunately, that's not how it's supposed to work today, at least. It must really be a directory containing only valid YAML files, or a local chart(with predefined FWIW, coincidentally, you can start including gotmpl files rendered by Helmfile before turning it into a temporary helm chart, like
True. But at least I have never tested it for turning helm templates into a chart. |
@mumoshu I gave this a try with the latest 0.139.0 release. Is there any documentation I can follow? I tried the following but the values are not rendered correctly:
Where the content of each file is:
The output of the command is (doesn't error out):
|
@vasrem As similar as values templates, only helmfile's environment and template context is available to .gotmpl. So just don't use release values. Instead use environment values.
or
|
I am trying to install a directory of K8s manifests as a chart as described in #1172 with the latest Helmfile v0.125.6 but it does not work properly.
Minimizing the example as much as possible, with a simply
and a single
.yaml
file inside the "chart" directory,helmfile template
produces the following errorUsing the previous v0.125.5 the same release is properly rendered.
Could be a possible regression? Or this feature is inteded to be used in a different way?
The text was updated successfully, but these errors were encountered: