Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FR: Use non-packaged chart from Git repositories #435

Closed
aslafy-z opened this issue Jan 15, 2019 · 4 comments · Fixed by #651
Closed

FR: Use non-packaged chart from Git repositories #435

aslafy-z opened this issue Jan 15, 2019 · 4 comments · Fixed by #651

Comments

@aslafy-z
Copy link

aslafy-z commented Jan 15, 2019

I'd love to be able to release from non-packages helm repositories, directly from git, with a ref and path specification.

Example:

repositories:
  - name: cert-manager
    git: https://github.com/jetstack/cert-manager
    ref: release-0.5
    path: contrib/charts

releases:
  - name: cert-manager
    chart: cert-manager/cert-manager
    namespace: networking
  - name: vault
    chart: cert-manager/vault
    namespace: security

See cert-manager and vault charts from here: https://github.com/jetstack/cert-manager/tree/release-0.5/contrib/charts

Note:

  • cert-manager has a requirements.yml which reference a local chart, so helm dependency update should be run for the chart before installing it, so the chart has to be considered as a local one.
  • We can use git sparse checkout to limit the fetch size

Related: #214

@aslafy-z aslafy-z changed the title Use non-packaged chart from Git repositories FR: Use non-packaged chart from Git repositories Jan 15, 2019
@mumoshu
Copy link
Collaborator

mumoshu commented Jan 16, 2019

@aslafy-z Hey! Thanks a lot for raising this issue!

I do hear about the exact use-case, which I find very useful. But I believe it is best solved by developing a helm downloader plugin, something like https://github.com/hypnoglow/helm-s3 but for github.

I'm eager to add a short guide for the usage once someone actually write one!

@aslafy-z
Copy link
Author

aslafy-z commented Jan 16, 2019

Thank you for the infos, I went ahead and made one: https://github.com/aslafy-z/helm-git

It:

  • Loads charts from SSH or HTTPS repos.
  • Build them if they aren't.
  • Update dependencies while building.
  • Allows to set Git ref (branch / tag / commit)
  • Allows to set sub-path to get charts (path/to/charts)

There are still work to do to make it resilient but it fits exactly my needs. I'd be so glad when I'll be able to use it within helmfile (#214).

@mumoshu
Copy link
Collaborator

mumoshu commented Jan 17, 2019

Hey. You are AWESOME!

Now I'd add a short guide for it.

In addition to that, I wonder if it would be even nicer if we start bundling selected helm plugins into our helmfile docker image. Yours and helm-s3(#220) would be the most requested ones. WDYT?

Btw, you don't need #214 to use your plugin with helmfile. Just install the helm plugin beforehand, and add your helm-git-backed chart repositories under repositories: in your helmfile.

@osterman
Copy link
Contributor

@aslafy-z this looks great! Going to add it to http://github.com/cloudposse/geodesic

We've been using https://github.com/sagansystems/helm-github, which doesn't support git schemes and therefore doesn't work well with helmfile. .

joshmyers added a commit to cloudposse/geodesic that referenced this issue Feb 4, 2019
We would like a a way to release from non-packages helm repositories, 
directly from git, with a ref and path specification. See [1]

`helm-git` supports `git` scheme making it compatible with `helmfile`

This closes [2]


[1] roboll/helmfile#435
[2] #355
joshmyers added a commit to cloudposse/geodesic that referenced this issue Feb 4, 2019
We would like a a way to release from non-packages helm repositories, 
directly from git, with a ref and path specification. See [1]

`helm-git` supports `git` scheme making it compatible with `helmfile`

This closes [2]


[1] roboll/helmfile#435
[2] #355
mumoshu added a commit that referenced this issue Jun 4, 2019
Resolves #435 (Git as chart repository)
Resolves #220 (S3 as chart repository)
Resolves #436 (About bundling helm plugins)

A lot of thanks to @aslafy-z for authoring the awesome helm-git plugin and contributing it to the community!
mumoshu added a commit that referenced this issue Jun 4, 2019
Resolves #435 (Git as chart repository)
Resolves #220 (S3 as chart repository)
Resolves #436 (About bundling helm plugins)

A lot of thanks to @aslafy-z for authoring the awesome helm-git plugin and contributing it to the community!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants