Add support for transitive dependencies (needs). #1983
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When using selectors in helmfile one can use the
--include-needs
parameter to also install the dependencies of the selected release(s). However, this doesn't work for transitive needs, only the direct needs of the specified releases will be included. The problem is described in more detail with an example here:#1915
Solution
After conferring with @mumoshu we decided to introduce a new parameter called
--include-transitive-needs
, which will also include transitive needs. We deliberately decided to not change the behavior of--include-needs
(even if including transitives might be the expected behavior for most users) to ensure backwards compatibility.Notes
--include-transitive-needs
will override any potential exclusions done by selectors or conditions. So even if you explicitly exclude a release via a selector it will still be part of the deployment in case it is a direct or transitive need of any of the specified releases.Fixes #1915
Closes #1915