fix: Make logging on unmatched selectors less verbose #217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mumoshu
force-pushed
the
less-verbose-unmatched-selector-logging
branch
from
d2322a5
to
ba030ae
Compare
mumoshu
force-pushed
the
less-verbose-unmatched-selector-logging
branch
from
ba030ae
to
fcb75fa
Compare
|
Thanks @mumoshu ! |
mumoshu
added a commit
to mumoshu/helmfile
that referenced
this pull request
Aug 24, 2018
Along with the fix for the bug introduced via roboll#217 Resolves roboll#219
mumoshu
commented
Aug 24, 2018
| @@ -607,7 +607,8 @@ func (state *HelmState) FilterReleases(labels []string) error { | |||
| filteredReleases = append(filteredReleases, r) | |||
| } | |||
| if len(filteredReleases) == 0 { | |||
| return fmt.Errorf("specified selector did not match any releases in %s\n", state.file) | |||
| state.logger.Debugf("specified selector did not match any releases in %s\n", state.file) | |||
| return nil | |||
There was a problem hiding this comment.
This broke helmfile's ability to filter the unmatched releases. Returning nil here means that you filter nothing.
#225 includes the fix for it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #200
Depends on #216 because this feature requires zap.SuggeredLogger to be passed to HelmState, which is done as part of #200