-
Notifications
You must be signed in to change notification settings - Fork 564
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Release Template #439
Conversation
249dbf5
to
2440b33
Compare
This feature is supposed to help advanced use-cases like Conventional Directory Structure explained in several issues like roboll#428. Newly added configuration keys `templates`, `missingFileHandler`, and the ability to defer executing template expressions in `values`, `secrets`, `namespace`, and `chart` of releases allows you to abstract away repetitions into a reusable template: ```yaml templates: default: &default missingFileHandler: Warn values: - config/{{`{{ .Release.Name }}`}}/values.yaml - config/{{`{{ .Release.Name }}`}}/{{`{{ .Environment.Name }}`}}.yaml secrets: - config/{{`{{ .Release.Name }}`}}/secrets.yaml - config/{{`{{ .Release.Name }}`}}/{{`{{ .Environment.Name }}`}}-secrets.yaml releases: - name: envoy namespace: "{{`{{ .Release.Name }}`}}" chart: stable/{{`{{ .Release.Name }}`}} <<: *default ``` See the updated documentation for more details. Resolves roboll#428
2440b33
to
b224781
Compare
@mumoshu That's cool |
Thanks! Let's see how this works in the wild. |
Thanks, I'll check this out. |
Just tested it out it's working great, but I do now get 50 messages of "skippping blah" per run. |
The repositories, templates, and environments block now takes about about 1/3rd of my file weighting in at 45 lines that is essentially duplicated between half a dozen helmfiles. |
Glad it worked 👍 Regarding the "skipping blah" logs, perhaps you'd need a better log-level for it, something other than |
Nice. Then we need "includes" for that, right? :) #380 |
And probably use a "global variable"(#398) across the helmfiles to locate the "library" helmfile that should be included to all of em. |
@mumoshu ya, something like debug would work great is that already support? I glanced at the code and it was not immediately apparent. |
It isn't supported yet, but should't be that hard to add. I'll do it later.
In the meantime, more feedbacks/idea on how to shape global vars and
includes or whatever works are appreciated.
I'm eager to reduce your repetitions!
2019年1月22日(火) 3:08 Shane Starcher <notifications@github.com>:
… @mumoshu <https://github.com/mumoshu> ya, something like debug would work
great is that already support? I glanced at the code and it was not
immediately apparent.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#439 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AABV-anJBFqQMHFAV1S2Vp1nVu2WoXTnks5vFgIYgaJpZM4aKO6A>
.
|
@mumoshu excellent thanks I'll think more about the globals. |
- Fix panics when `missingFileHandler` is not defined - Fix `missingFileHandler: Error` had been writing errors at the Warn level - Add `Info` and `Debug` as valid values Ref roboll#439 (comment)
#440 adds |
- Fix panics when `missingFileHandler` is not defined - Fix `missingFileHandler: Error` had been writing errors at the Warn level - Add `Info` and `Debug` as valid values Ref #439 (comment)
There was a regression introduced by roboll#439 that broke the first-pass rendering completely. This fixes that.
There was a regression introduced by #439 that broke the first-pass rendering completely. This fixes that.
Sorry to bring this PR back to life, but got a question about this feature. Any particular reason why the |
several fields are not templated such as labels, but that feature could be added. |
@georgevella Would you mind creating an issue to track that? Thanks! |
Just for reference, templating for labels is tracked in #446 |
This feature is supposed to help advanced use-cases like Conventional Directory Structure explained in several issues like #428.
Newly added configuration keys
templates
,missingFileHandler
, and the ability to defer executing template expressions invalues
,secrets
,namespace
, andchart
of releases allows you to abstract away repetitions into a reusable template:See the updated documentation for more details.
Resolves #428