This repository has been archived by the owner on Jan 7, 2019. It is now read-only.
Deduplicate and clean up linker scripts #188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This extracts all the common sections and moves them into a macro file, allowing for less code duplication and easier changing of what goes into sections and how they are structured.
Some sections are unused, or make no sense on Cortex-M. Includes minor style cleanup.
|
This has now been tested in hardware on all supported platforms. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deduplication by using Jinja2 macros to deduplicate the linker script formatting followed by clean up of unused or pointless linker sections.
I believe most of the original linker script code comes from @dergraaf. Please review the removal of the sections, in case I missed something.
Note: This requires review and testing in hardware.
cc @ekiwi @strongly-typed.