Skip to content
This repository has been archived by the owner on Jan 7, 2019. It is now read-only.

[boost] Use C++11 stdlib classes instead of boost. #322

Merged
merged 1 commit into from
Jan 6, 2018
Merged

[boost] Use C++11 stdlib classes instead of boost. #322

merged 1 commit into from
Jan 6, 2018

Conversation

salkinium
Copy link
Member

Trying to reduce the dependence on boost for xpcc for #316 (comment).

However, we use Boost.Asio for xpcc::hosted::SerialPort and there is no replacement in the stdlib for that. So I don't think we can get rid of all of boost.

In addition there is no replacement for boost::this_thread::disable_interruption, which breaks the API at the moment.

cc @strongly-typed @dergraaf

@emgre
Copy link

emgre commented Dec 22, 2017

If you don't want to depend on boost for serial stuff, you can use the standalone Asio library : https://think-async.com/Asio/AsioStandalone

@salkinium
Copy link
Member Author

In addition there is no replacement for boost::this_thread::disable_interruption, which breaks the API at the moment.

Never mind, std::thread is not interruptible anyways, so I just made this an empty class.

If you don't want to depend on boost for serial stuff, you can use the standalone Asio library

Great! That will remove our need for all of boost for hosted. I'll refactor it later.

@salkinium salkinium self-assigned this Jan 3, 2018
@salkinium
Copy link
Member Author

cc @dergraaf Please review these changes, since you wrote most of the affected code. The stdlib changes are based on boost anyways, so this is basically just a fancy find/replace, but please confirm that I implemented xpcc::rtos::Thread::Lock correctly!

@salkinium salkinium merged commit 5ef8009 into roboterclubaachen:develop Jan 6, 2018
@salkinium salkinium deleted the feature/boost_stdlib branch January 7, 2018 17:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants