-
Notifications
You must be signed in to change notification settings - Fork 39
[driver] Block device: Add missing include #335
[driver] Block device: Add missing include #335
Conversation
How the heck do we still use avr-gcc-4.9.2 for Circle CI? It was released in October 30, 2014. Gee. 😉 |
Because Ubuntu and most other distributions only ship the official toolchain which is stuck at gcc v5.4.0. That's okish, except it contains a compiler bug, which breaks modm CI, so now I'm building a completely new image using archlinux, which has avr-gcc v7.2.0. |
GCC 5.4 should be fine for this PR. |
I've given up on Arch, it didn't have zmqpp headers. I've instead just compiled avr-gcc v7.2.0 + binutils for Ubuntu 17.10 here to use in our current Ubuntu based CircleCI images. |
There's an AUR package for that: https://aur.archlinux.org/packages/zmqpp/ |
And… there are issues with linking against system libraries. I don't feel like debugging archlinux on a docker image running in CircleCI. I mean there is a limit to my masochist tendencies. |
Interesting, it's running smoothly on my system.
However, this makes sense too 😄 |
CircleCI is now running avr-gcc 7, but:
Happy debugging ^^ |
Because: CircleCI still uses
|
6a2d848
to
e068490
Compare
In
driver/block_device_mirror.hpp
std::max()
is used, but#include <algorithm>
was missing.Additionally
std::min()
andstd::max()
in the mock-up stdc++ implementation are now constexpr and a example for AVR was added (but not tested in hardware).Furthermore
BlockDevice::DeviceSize
was added.