-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Odometry readjustement #28
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The idea is to re-adjust odometry considering the stamp of the adjust odometry tf given in the callback
In fact there is a little error at each stage that amplifies slowly, but we can get rid of it by manipulating troncated double. A precision of about a millimeter is still remaining which is acceptable.
PhileasL
commented
Feb 7, 2021
@@ -10,6 +10,7 @@ | |||
#include <webots/PositionSensor.hpp> | |||
#endif | |||
#include "std_srvs/srv/set_bool.hpp" | |||
#include "std_srvs/srv/trigger.hpp" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, i forget to remove that
3wnbr1
approved these changes
Feb 7, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, Well done 👍
PhileasL
added a commit
that referenced
this pull request
Feb 8, 2021
PhileasL
added a commit
that referenced
this pull request
Feb 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Idea
The idea is to give to drive the real position of the robot at a given stamp. The goal for drive is to set odom_pose_ with this information.
Problem:
The position given is obviously from the past.
Solution:
Observations
The goal of this method isn't to perfectly re-adjust the odometry, but to reduce the error of the odometry between the last re-adjustment and the nearest stored tf from the stamp of the given TransformStamped.
This can re-adjust odometry up to 0.75s from the past.