ctrlLib defines math symbols to avoid referring to M_PI in the headers #259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm going to check sister projects compilation. |
pattacini
force-pushed
the
fix/define-math-symbols
branch
from
88df402 to
4ad8ec1
Compare
pattacini
added a commit
that referenced
this pull request
Dec 22, 2015
ctrlLib defines math symbols to avoid referring to M_PI in the headers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following up discussions in robotology/community#81,
ctrlLibdeclares now math symbols within its own namespace to avoid referring explicitly to e.g.M_PIin the public headers.To get
icub-maincompiled I had to apply changes here and there. I'm afraid that this new approach will have an impact on sister projects: I think it is no longer guaranteed that they'll compile smoothly.