Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CanBusMotionControl: do not raise error if motorPwmLimit is not found #662

Merged
merged 1 commit into from
Jun 22, 2020

Conversation

traversaro
Copy link
Member

If motorPwmLimit is not found, the default limit of 1333 is used instead, and a warning is printed.
For this reason, it does not make sense to print an error if motorPwmLimit is not found.

@traversaro
Copy link
Member Author

traversaro commented Jun 19, 2020

cc @xEnVrE @randaz81

@randaz81
Copy link
Member

The reason why is set to Error is because I originally wanted to avoid optional parameters (keeping them temporarily for backward compatibility) and proceed to fix all robot configuration files until all of them have the same set of parameters, and no optional values. This allows to perform easily automatic search and replace operation via xquery. This policy may be reconsidered now, if you wish.

@pattacini
Copy link
Member

Thanks for the rationale @randaz81 👍

My hunch is that we could proceed further anyhow without waiting for the big overhaul to be completed. Soon afterward, we'll be able to get back to this.

How do you see that?

If motorPwmLimit is not found, the default limit of 1333 is used instead, and a warning is printed. 
For this reason, it does not make sense to print an error if motorPwmLimit is  not found.
@pattacini pattacini merged commit d61630c into devel Jun 22, 2020
@pattacini pattacini deleted the fix-motorPwmLimit branch June 22, 2020 09:53
@randaz81
Copy link
Member

Ok! I'd suggest to keep an issue open on that, because optional/default values already caused weird issues in the past...

@pattacini
Copy link
Member

Let me open up an issue in robots-configuration @randaz81

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants