embobjMotionControl: fix windows execution #703
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Under Windows using `reserve` without any `resize` throws a "out of range" exception. This is due to the fact that after that `reserve` the `capacity` is `nj`, the size is `0`. I am surprised that this code is allowed under linux, but maybe I am missing something. BTW this code is tested on windows and it works
Nicogene
requested review from
traversaro,
pattacini,
ale-git and
marcoaccame
pattacini
approved these changes
Dec 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Under Windows using
reservewithout anyresizethrows a "out of range" exception.This is due to the fact that after that
reservethecapacityisnj, the size is0.I am surprised that this code is allowed under linux, but maybe I am missing something.
BTW this code is tested on windows and it works