-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
packets_creation: add the icub packet creation via gh action #709
packets_creation: add the icub packet creation via gh action #709
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice addition @Nicogene 👍🏻
I've got a few points to address.
Another problem I can see is that we tend to modify the release tag a few times before carving it on the stone to fix some last minutes mistakes. Therefore, I'd avoid triggering the action upon the creation of just the tag. Instead, I'd go for one of the following options:
|
62ed31a
to
bb13b67
Compare
No directly related to this PR, but I guess this is an residual related to when releases were "expensive". If the release process is completely automated, there is nothing particularly problematic in quickly releasing small patch releases that fix small bugs or problems.
The problem of using |
# Probably this step is not needed anymore after cmake components/modernization | ||
fix_relocatable_files |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bb13b67
to
9982332
Compare
I didn't explain exactly what I meant. In the recent past, @Nicogene can confirm, we tagged the master and then craft the releases a few days afterward. In the time between, it (rarely) happened that the same tag was deleted and updated before announcing the "real" (corresponding) release. That's the point why I'm not really confident in triggering this workflow upon the creation of the tag but rather upon the creation of the actual release (and I'm pretty sure we can do that). Generally speaking, I concur with you @traversaro that once we release a piece of software we can then easily fix possible bugs with subsequent patches, especially when the process is almost fully automatized. That said, option 1 (triggering upon releases rather than tag) is obviously preferable over option 2 - which by the way I meant to be using at the very same time when the release is ready, although it's certainly not an atomic operation. |
9982332
to
178587f
Compare
c6dfa13
to
9119203
Compare
48212d3
to
4edfbec
Compare
Update @pattacini now the action is triggered by the creation of a new release 👍🏻 See https://github.com/Nicogene/icub-main/actions/runs/469222425 for reference and the relative release https://github.com/Nicogene/icub-main/releases/tag/v1.0.57 |
4edfbec
to
f52cb38
Compare
This PR adds the creation of the
icub
packet via gh actionSee https://github.com/Nicogene/icub-main/actions/runs/463171210 for reference and here the deb uploaded