Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support of 7 joints in the mk3 hand #744

Merged
merged 4 commits into from
Apr 27, 2021
Merged

Support of 7 joints in the mk3 hand #744

merged 4 commits into from
Apr 27, 2021

Conversation

marcoaccame
Copy link
Contributor

@marcoaccame marcoaccame commented Apr 12, 2021

Aim of the PR

This PR allows yarprobotinterface to manage the 7 joints of the mk3 hand for what is about the FW on the mc4plus and pmc boards.

This PR is part of a set of PRs which should be processed all together. More details are in here.

For the sake of this repo, the changes have been limited to:

  • the way embObjMotionControl parses the xml files of mode called eomn_serv_MC_mc4pluspmc and forms the data structure required for its configuration.
  • requirement of a new version of icub-firmware-shared which is now still in a private fork (see the PR). For this reason, ... I suspect that the test of continuous integration will fail (cc @pattacini).

@pattacini pattacini marked this pull request as draft April 12, 2021 10:22
@pattacini
Copy link
Member

If it's still WIP then better off converting it to draft.

@marcoaccame marcoaccame changed the title [WIP] Support of 7 joints in the mk3 hand Support of 7 joints in the mk3 hand Apr 26, 2021
@marcoaccame marcoaccame marked this pull request as ready for review April 27, 2021 07:08
@marcoaccame
Copy link
Contributor Author

Hi @pattacini, there is this set of PRs described in here because they all start from changes in FW. They all are dependent on each other.

The PRs are ready now. It think that the evaluation could start from here in icub-main. Can you have a look at that?

As I wrote, the continuous integration fails because of the need of a specific version of icub-firmware-shared which is also under PR.

@pattacini
Copy link
Member

pattacini commented Apr 27, 2021

As I wrote, the continuous integration fails because of the need of a specific version of icub-firmware-shared which is also under PR.

So, better off reviewing/merging that first.

@pattacini
Copy link
Member

robotology/icub-firmware-shared#47 merged ✔
Just started over CI.

@pattacini pattacini merged commit 3ed9f1c into robotology:devel Apr 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants