Fix placing of shared libraries in Windows #790
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #784.
@sgiraz narrowed down the reason why part of the libraries was ok and part not. See below.
I've also reinstated the test stage of the CI on Windows.
After a quick comparison between commit 87cd0a1 and commit b6e0f7b I found the difference that caused the "fix".
In particular in
src/libraries/icubmod/embObjLib/CMakeLists.txt
we have the following difference:As we can see, the SHARED keyword has been removed in b6e0f7b.