Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix placing of shared libraries in Windows #790

Merged
merged 1 commit into from
May 13, 2022
Merged

Fix placing of shared libraries in Windows #790

merged 1 commit into from
May 13, 2022

Conversation

pattacini
Copy link
Member

@pattacini pattacini commented May 13, 2022

This PR fixes #784.

@sgiraz narrowed down the reason why part of the libraries was ok and part not. See below.

I've also reinstated the test stage of the CI on Windows.


After a quick comparison between commit 87cd0a1 and commit b6e0f7b I found the difference that caused the "fix".

In particular in src/libraries/icubmod/embObjLib/CMakeLists.txt we have the following difference:

- add_library(${PROJECT_NAME} SHARED ${embobj_source} ${embobj_header})
+ add_library(${PROJECT_NAME} ${embobj_source} ${embobj_header})

As we can see, the SHARED keyword has been removed in b6e0f7b.

@pattacini pattacini merged commit 0a2221a into devel May 13, 2022
@pattacini pattacini deleted the fix/784 branch May 13, 2022 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some libraries and executables could be placed in the wrong path during the build process
2 participants