Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update embObjMotionControl and eomcParser to manage the new Kalman Filter paramenters #799

Merged
merged 3 commits into from
Jun 21, 2022

Conversation

sgiraz
Copy link
Contributor

@sgiraz sgiraz commented May 24, 2022

What's new in this PR:

  • eomcParser is now able to parse and manage the new Kalman Filter parameters from XML files: kalmanFilterEnabled, x0, x1, x2, Q0, Q1, Q2, R and P0. Here is an example (for one joint) of how they should be included in hardware\motorControl\<board-joint>-mc.xml
<group name="KALMAN_FILTER">
    <param name="kalmanFilterEnabled">          1                     </param>
    <param name="x0">                           0                     </param>
    <param name="x1">                           0                     </param>
    <param name="x2">                           0                     </param>
    <param name="Q0">                           0.0001                </param>
    <param name="Q1">                           0.01                  </param>
    <param name="Q2">                           10                    </param>
    <param name="R">                            0.0001                </param>
    <param name="P0">                           0.000099              </param>
</group>

Note:

  • The integration has been tested on a custom single joint setup (mc4plus + DC motor + aea2) and iCubGenova02(🟣).

@sgiraz
Copy link
Contributor Author

sgiraz commented May 24, 2022

Note: This PR shouldn't be merged until YARP 3.7 has been released

cc @pattacini

@pattacini pattacini self-requested a review May 24, 2022 09:44
@sgiraz sgiraz marked this pull request as ready for review June 17, 2022 09:24
@pattacini
Copy link
Member

pattacini commented Jun 17, 2022

CI has failed because we need to merge robotology/icub-firmware-shared#64 first.

cc @sgiraz

Noo it parses the new KALMAN_FILTER  group and stop yarprobotinterface when the group is present, but some param is missing.
Copy link
Contributor

@marcoaccame marcoaccame left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@pattacini
Copy link
Member

Just awaiting the CI before merging.

@pattacini pattacini merged commit 3a62c7d into robotology:devel Jun 21, 2022
@sgiraz sgiraz deleted the feat/kf_params branch July 13, 2022 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants