Fix net performance tool in embObjLib #804
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
pattacini
approved these changes
Jun 7, 2022
There was a problem hiding this comment.
Thanks @valegagge @vvasco 👍🏻
Fine with me.
Don't know whether @marcoaccame wants to review it otherwise I'll be happy to merge the PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alongside with @vvasco, we fixed the tools inside the embObjLib for test network performance.
In details:
NETWORK_PERFORMANCE_BENCHMARK, that enables the tool, works properly.Emb_PeriodicEventVerifier: now it uses the correct measure units.We already used these changes to test the network performance on a robot. All is fine.