Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed handling of temperature in MultipleFT service #811

Merged
merged 1 commit into from
Jun 29, 2022
Merged

Fixed handling of temperature in MultipleFT service #811

merged 1 commit into from
Jun 29, 2022

Conversation

triccyx
Copy link
Member

@triccyx triccyx commented Jun 29, 2022

Bug fix relating to temperature acquisition period for multiple FT sensor device

@pattacini pattacini changed the title fix bug Fixed handling of temperature in MultipleFT service Jun 29, 2022
Copy link
Member

@pattacini pattacini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awaiting the CI and then merging.

Copy link
Contributor

@marcoaccame marcoaccame left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested the changes on my HW setup and now the rate of TX of temperature is correct

@traversaro
Copy link
Member

traversaro commented Jun 29, 2022

Just to understand, what happened before this PR? I guess that period was parsed as seconds instead of milliseconds, so the temperature in existing boards that used embObjMultipleFTsensors was streamed only every 1000/60 = 16 minutes? Or there was something else mitigating this?

fyi @HosameldinMohamed

@pattacini pattacini merged commit 26c53cf into robotology:master Jun 29, 2022
@triccyx
Copy link
Member Author

triccyx commented Jun 29, 2022

Just to understand, what happened before this PR? I guess that period was parsed as seconds instead of milliseconds, so the temperature in existing boards that used embObjMultipleFTsensors was streamed only every 1000/60 = 16 minutes? Or there was something else mitigating this?

fyi @HosameldinMohamed

@traversaro
Two things:

  • Period read in msec but not correctly transformed in sec. For example, 10 msec in XML became 10 sec
  • If you have used a period > 253 the period became always 253 (cast to uint8)

@triccyx triccyx deleted the tempeature-period-fic branch June 29, 2022 10:41
@traversaro
Copy link
Member

Ack! So basically the temperature on the FT sensors of the foot of iCub3 (the only robot where embObjMultipleFTsensors is used at the moment) even if the .xml request 1000 (i.e. one seconds) was actually updated every 253 seconds, i.e. 4 minutes and 13 seconds.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants