Fix BUILD_SHARED_LIBS set to ON and add test #854
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
traversaro
changed the title
pattacini
changed the title
traversaro
changed the title
pattacini
requested changes
Jan 30, 2023
There was a problem hiding this comment.
Thanks @traversaro!
f we want to avoid to double the number of tests, we can also switch to use BUILD_SHARED_LIBS by default.
Let's keep it this way for the time being; we can streamline it later.
There's just one comment needing your attention.
Co-authored-by: Ugo Pattacini <ugo.pattacini@iit.it>
pattacini
approved these changes
Jan 31, 2023
|
CI on macOS just failed because of timeout. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ädd missing link between
strainCalibLibandcanLoaderLibto fix compilation withBUILD_SHARED_LIBSset toON. To avoid future regressions, I also added tests with BUILD_SHARED_LIBS=ON . If we want to avoid to double the number of tests, we can also switch to useBUILD_SHARED_LIBSby default.