Support joints publishing on ROS 2 for iCubGazeboV2_5_visuomanip #211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can I ask if there are update on this? Thank you cc @Nicogene |
Sorry, I lost this notification. In the future to not worry about pinging as this can happens. For me this is ok.
This is a problem for which we need to find a solution. I opened #212 to fix this, even If I do not know a solution. |
traversaro
reviewed
Oct 3, 2023
...manual/conf_manual/iCubGazeboV2_5_visuomanip/wrappers/motorControl/alljoints-mc_remapper.xml
Outdated
Show resolved
Hide resolved
traversaro
approved these changes
Oct 3, 2023
xEnVrE
force-pushed
the
impl/icubgazebov25_ros2_joint_pub
branch
from
082fb3f
to
9187528
Compare
traversaro
reviewed
Oct 3, 2023
...manual/conf_manual/iCubGazeboV2_5_visuomanip/wrappers/motorControl/alljoints-mc_nws_ros2.xml
Outdated
Show resolved
Hide resolved
traversaro
reviewed
Oct 3, 2023
...manual/conf_manual/iCubGazeboV2_5_visuomanip/wrappers/motorControl/alljoints-mc_remapper.xml
Outdated
Show resolved
Hide resolved
Nicogene
approved these changes
Oct 3, 2023
xEnVrE
force-pushed
the
impl/icubgazebov25_ros2_joint_pub
branch
from
9187528
to
22b201b
Compare
|
Should I edit the |
|
If you like, yes, thanks! |
xEnVrE
force-pushed
the
impl/icubgazebov25_ros2_joint_pub
branch
2 times, most recently
from
370f060
to
96e96b1
Compare
|
|
|
If there are no other comments from your side, would it be possible to merge it? Thank you |
traversaro
requested changes
Oct 3, 2023
xEnVrE
force-pushed
the
impl/icubgazebov25_ros2_joint_pub
branch
from
96e96b1
to
e50f538
Compare
traversaro
approved these changes
Oct 3, 2023
|
Thanks @xEnVrE ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per the title.
It adds an
icub_ros2.xml, mimicking that ofiCubGenova11which, similary toiCubGazeboV2_5_visuomanip, does not have legs enabled.Using this file, instead of
icub.xml, inicub-models/iCub_manual/robots/iCubGazeboV2_5_visuomanip/model.urdf
Line 2753 in 9f5e04b
a standard ROS2-based robot state publisher can be executed.
Notes:
unfortunately,
icub_ros2.xmlcannot be made the default as it is not granted that each user oficub-modelsis also usingyarp-ros2-devices.fingers and eyes are not exposed as, at the moment, the robot state publisher would not know how to extract the physical joint from the coupled ones. I can add them in the future once the development in IJointCoupling: an interface for handling coupled joints yarp#3026 is completed.
cc @traversaro