Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop compatibility with Xcode 12 #534

Merged
merged 10 commits into from
Nov 26, 2020
Merged

Drop compatibility with Xcode 12 #534

merged 10 commits into from
Nov 26, 2020

Conversation

traversaro
Copy link
Member

@traversaro traversaro commented Nov 24, 2020

For the motivations described in robotology/ycm-cmake-modules#368, supporting Xcode 12 is quite complicated at the moment, so we just remove it from the CI jobs and we will document that we don't support it.

While we wait 0.12.1 release, let's at least fix #525 .
@drdanz
Copy link
Member

drdanz commented Nov 24, 2020

For reference, I'm planning to release 0.12.1 in a couple of days...

@traversaro
Copy link
Member Author

For reference, I'm planning to release 0.12.1 in a couple of days...

Exactly, this is for starting gaining time and test the 0.12.1 on all the CIs jobs, and catch early any possible problem.

@traversaro traversaro requested a review from lrapetti November 24, 2020 09:35
@traversaro
Copy link
Member Author

For reference, I'm planning to release 0.12.1 in a couple of days...

Exactly, this is for starting gaining time and test the 0.12.1 on all the CIs jobs, and catch early any possible problem.

Indeed, CI is still not working.

@drdanz
Copy link
Member

drdanz commented Nov 24, 2020

I'll stand by for the release then 😆

@traversaro
Copy link
Member Author

For reference, I'm planning to release 0.12.1 in a couple of days...

Exactly, this is for starting gaining time and test the 0.12.1 on all the CIs jobs, and catch early any possible problem.

Indeed, CI is still not working.

There were still some problem, hopefully fixed by robotology/ycm-cmake-modules#367 . As a test I included the commit of the PR in the release file for now.

@traversaro
Copy link
Member Author

The version of YCM set in the .yaml was ignored, because there was a bug in the .yaml file because YCM was referred with the repo name ycm, instead of which the CMake package name YCM . This is not the first time it happens, so it is better to open an issue on how to to fix this in the long term.

@traversaro
Copy link
Member Author

Ok, now a new error:

-- Generating done
  The custom command generating

    /Users/runner/work/robotology-superbuild/robotology-superbuild/build/robotology/YCM/CMakeFiles/YCMStamp/$(CONFIGURATION)$(EFFECTIVE_PLATFORM_NAME)/YCM-mkdir

  is attached to multiple targets:

    YCM-update
    YCM

  but none of these is a common dependency of the other(s).  This is not
  allowed by the Xcode "new build system".


CMake Generate step failed.  Build files cannot be regenerated correctly.

@traversaro traversaro changed the title Bump YCM checkout in 2020.11 Fix YCM compatibility with Xcode 12 Nov 25, 2020
@traversaro traversaro changed the title Fix YCM compatibility with Xcode 12 Drop compatibility with Xcode 12 Nov 25, 2020
@traversaro traversaro merged commit 3d8f5f9 into master Nov 26, 2020
@traversaro traversaro deleted the traversaro-patch-2 branch November 26, 2020 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants