updated plumb bob distortion #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@traversaro fyi |
Ok for me, I just suggest to also bump the required YARP version in https://github.com/robotology/yarp-device-realsense2/blob/master/CMakeLists.txt#L53 and add a line to the changelog? |
Nicogene
approved these changes
Apr 5, 2022
ste93
force-pushed
the
plumb_bob_distortion_fix
branch
2 times, most recently
from
0a5ed32 to
c9e9c90
Compare
|
as said in #10 updated in order to have distortion none |
ste93
commented
Apr 11, 2022
|
@ste93 I revised the CHANGELOG, feel free to check it out for the future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
since robotology/yarp#2544 has been closed then we can do this fix? also related to #10, maybe is better to put distortion none?