Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/i chat bot interface #3019

Merged
merged 12 commits into from
Sep 18, 2023

Conversation

elandini84
Copy link
Contributor

IChatBot

  • Added a yarp interface to interact with chatbots. It allows to send messages and receive answers and to manage the bot language.

  • This does not features "implementation-specific" functionalities that could benefit the user but are not universally available among the various chatbot that can be found online. The idea is to open new PR in the future with new interfaces derived from yarp::dev::IChatBot that will model different "classes" of
    chatbots (an example on how chatbots can be classified, can be found in this article: A critical review of state-of-the-art chatbot designs and applications)

New interface for interacting with chatbots. This is just a generic one
that do not take advantages of "implementation-specific" features. It
just allows to set the bot language and to interact with it.
The yarp/src/devices CMakeLists file has been updated too
@elandini84 elandini84 added PR Type: Feat/Enh This PR adds some new feature or enhances some part of YARP Component: Devices Target: YARP v3.9.0 labels Sep 12, 2023
@elandini84 elandini84 self-assigned this Sep 12, 2023
Changed files accordingly to the suggestions given by the reviewer.
Removed also unnecessary port from IChatBotMsgsImpl.
@elandini84 elandini84 temporarily deployed to code-analysis September 12, 2023 15:38 — with GitHub Actions Inactive
@elandini84 elandini84 temporarily deployed to code-analysis September 12, 2023 15:38 — with GitHub Actions Inactive
randaz81

This comment was marked as outdated.

randaz81

This comment was marked as outdated.

@elandini84 elandini84 temporarily deployed to code-analysis September 15, 2023 08:59 — with GitHub Actions Inactive
@elandini84 elandini84 temporarily deployed to code-analysis September 15, 2023 08:59 — with GitHub Actions Inactive
@elandini84 elandini84 temporarily deployed to code-analysis September 15, 2023 08:59 — with GitHub Actions Inactive
@elandini84 elandini84 temporarily deployed to code-analysis September 15, 2023 15:02 — with GitHub Actions Inactive
@elandini84 elandini84 temporarily deployed to code-analysis September 15, 2023 15:02 — with GitHub Actions Inactive
@elandini84 elandini84 temporarily deployed to code-analysis September 15, 2023 15:02 — with GitHub Actions Inactive
@elandini84 elandini84 temporarily deployed to code-analysis September 18, 2023 12:18 — with GitHub Actions Inactive
@elandini84 elandini84 temporarily deployed to code-analysis September 18, 2023 12:18 — with GitHub Actions Inactive
@elandini84 elandini84 temporarily deployed to code-analysis September 18, 2023 12:18 — with GitHub Actions Inactive
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 44 Code Smells

41.2% 41.2% Coverage
9.8% 9.8% Duplication

warning The version of Java (11.0.3) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@randaz81 randaz81 merged commit 4fa591d into robotology:master Sep 18, 2023
42 of 50 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Devices PR Type: Feat/Enh This PR adds some new feature or enhances some part of YARP
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants