Fix for issue #975 - Adding warning when plugin has a wrong library parameter #989
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drdanz
suggested changes
Dec 1, 2016
| @@ -87,7 +87,10 @@ class DriversHelper : public YarpPluginSelector { | |||
| settings.readFromSearchable(prop,name); | |||
| settings.open(lib); | |||
| ConstString location = lib.getName().c_str(); | |||
| if (location=="") continue; | |||
| if (location=="") { | |||
There was a problem hiding this comment.
Is location set empty after the library failed loading? Or does this work only for empty location? Do you mind adding a comment here to explain?
There was a problem hiding this comment.
I tried by putting a wrong library name and it enters the if. So yes, wrong library name gives an empty location. I'll add a comment.
drdanz
added
Component: Library - YARP_dev
Target: YARP v2.3.68.1
PR Type: Feat/Enh
drdanz
force-pushed
the
fixPluginLibraryWarning
branch
from
411d00a
to
fea1fa5
Compare
drdanz
approved these changes
Dec 2, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.