Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrected annotation #776

Merged
merged 3 commits into from
Nov 18, 2024
Merged

Corrected annotation #776

merged 3 commits into from
Nov 18, 2024

Conversation

knutnergaard
Copy link
Contributor

@knutnergaard knutnergaard commented Nov 18, 2024

This adresses mypy errors raised after refactoring of annotations.py and annotation of normalizers.py.

The following errors presist, which will be collected in #775:

font.py:64: error: Signature of "_reprContents" incompatible with supertype "BaseObject"  [override]
font.py:64: note:      Superclass:
font.py:64: note:          @classmethod
font.py:64: note:          def _reprContents(cls) -> List[str]
font.py:64: note:      Subclass:
font.py:64: note:          def _reprContents(self) -> List[str]
font.py:2061: error: Signature of "isCompatible" incompatible with supertype "InterpolationMixin"  [override]
font.py:2061: note:      Superclass:
font.py:2061: note:          def isCompatible(self, other: Any, cls: Type[Any]) -> Tuple[bool, Any]
font.py:2061: note:      Subclass:
font.py:2061: note:          def isCompatible(self, other: BaseFont) -> Tuple[bool, str]
font.py:2138: error: "str" has no attribute "fatal"  [attr-defined]
font.py:2138: error: "str" has no attribute "warning"  [attr-defined]
font.py:2139: error: "str" has no attribute "fatal"  [attr-defined]
font.py:2141: error: "str" has no attribute "warning"  [attr-defined]

Copy link
Member

@benkiel benkiel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two things, one just a question.

Lib/fontParts/base/font.py Show resolved Hide resolved
Lib/fontParts/base/font.py Show resolved Hide resolved
@benkiel
Copy link
Member

benkiel commented Nov 18, 2024

@knutnergaard I quickly took care of that docstring issues, merging

@benkiel benkiel merged commit bcf1da5 into robotools:v1 Nov 18, 2024
9 checks passed
@knutnergaard knutnergaard mentioned this pull request Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants