Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve mypy errors. #807

Merged
merged 9 commits into from
Dec 5, 2024
Merged

Resolve mypy errors. #807

merged 9 commits into from
Dec 5, 2024

Conversation

knutnergaard
Copy link
Contributor

No description provided.

@knutnergaard knutnergaard marked this pull request as ready for review December 5, 2024 19:49
@knutnergaard knutnergaard mentioned this pull request Dec 5, 2024
Open
@benkiel benkiel merged commit 56a51c0 into robotools:v1 Dec 5, 2024
10 checks passed
@benkiel
Copy link
Member

benkiel commented Dec 5, 2024

Actually, looking at this again, is it right that cls=None?

@knutnergaard
Copy link
Contributor Author

@benkiel It's either that or raise an error if a value is passed to the cls parameter. None of the files changed in this PR had a cls parameter in isCompatible at all, so it better not be mandatory. Of the two alternatives, I think the first is less intrusive and more backwards compatible, in case the cls is used in some weird way I'm not thinking of.

@benkiel
Copy link
Member

benkiel commented Dec 6, 2024

Got it. Cool.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benkiel benkiel benkiel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@knutnergaard @benkiel