add failing test #3
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@robrichard i fixed the bug in main see graphql#3993 i changed the test slightly, added |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this failing test is the reason why i had to explicitly prune any masked defer usages from the defer usage set.
[Parenthetically, once I had done that, it was easy to just save the result, and so that led me down the path of comparing each field's pruned defer usage set to its parent field's defer usage set, rather than what I see your PR doing in comparing it to the unpruned "parent" incremental data record's defer usage set. I am not sure which way is better, but the above case must be dealt with somehow.
As an aside, there is a bug on main as well with this test where it emits an unnecessary pending...