Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Path.notToBeExecutable #1015

Closed
rhushikesh opened this issue Oct 17, 2021 · 2 comments · Fixed by #1016
Closed

add Path.notToBeExecutable #1015

rhushikesh opened this issue Oct 17, 2021 · 2 comments · Fixed by #1016
Assignees
Milestone

Comments

@rhushikesh
Copy link
Contributor

Platform (all, jvm, js): jvm
Extension (none, kotlin 1.3): none

Code related feature
expect(path).notToBeExecutable()

//instead of

expect(path).feature { f(it::isExecutable) }.toEqual(false)
Following the things you need to do:

logic

extend PathAssertions with a function isNotExecutable (see PathAssertions as a guideline)
implement isNotReadable in DefaultPathAssertions.kt by using the ExpectImpl.feature.extractor...
run ./gradlew generateLogic which will update path.kt in logic
api-fluent

provide a function notToBeExecutable which returns Expect in pathExpectations.kt (see pathExpectations.kt toBeExecutable as a guideline)
add @SInCE 0.17.0 (adapt to current milestone) to KDOC
extend or write a separate Spec named PathExpectationsSpec in specs-common (see for instance PathExpectationsSpec) and extend it in atrium-api-fluent-en_GB-common/src/test
api-infix

provide a function notToBeExecutable which returns Expect in pathExpectations.kt (see pathExpectations.kt toBeExecutable as a guideline)
add @SInCE 0.17.0 (adapt to current milestone) to KDOC
extend or write a separate Spec named PathExpectationsSpec in specs-common (see for instance PathExpectationsSpec) and extend it in atrium-api-infix-en_GB-common/src/test
Your first contribution?
Write a comment I'll work on this if you would like to take this issue over.
This way we get the chance to revise the description in case things have changed in the meantime, we might give you additional hints and we can assign the task to you, so that others do not start as well.
See Your first code contribution for guidelines.
Do not hesitate to ask questions here or to contact us via Atrium's slack channel if you need help
(Invite yourself in case you do not have an account yet).

@rhushikesh
Copy link
Contributor Author

Hi @robstoll, should we have an issue to create Path.notToBeExecutable. If this is required then I can pick it up

@rhushikesh
Copy link
Contributor Author

Hi @robstoll, I have raised PR for this issue #1016. Please have a look and let me know. Also can you please add Hacktoberfest label to this issue as well

@robstoll robstoll added this to the 0.17.0 milestone Oct 17, 2021
@robstoll robstoll linked a pull request Oct 17, 2021 that will close this issue
robstoll pushed a commit that referenced this issue Oct 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants