Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add samples for fun0Expectations also to api-infix #1044

Closed
3 tasks
robstoll opened this issue Nov 4, 2021 · 1 comment · Fixed by #1099
Closed
3 tasks

add samples for fun0Expectations also to api-infix #1044

robstoll opened this issue Nov 4, 2021 · 1 comment · Fixed by #1099
Assignees
Labels
Milestone

Comments

@robstoll
Copy link
Owner

robstoll commented Nov 4, 2021

Platform (all, jvm, js, android): all
Extension (none, kotlin 1.3): none

Code related feature

We also want to provide samples for the infix api

Following the things you need to do:

  • copy Fun0ExpectationSamples from fluent-api to api-infix, adjust imports ...api.fluent... to ...api.infix... and adjust the samples accordingly (always use the infix syntax, never the fluent).
    • take a look at existing Samples (e.g. ListFeatureExtractorSamples) in api-infix for how to format comments
  • check that the sample in the KDoc Intellij is showing looks good (ALT+Mouse-click on function name)

Your first contribution?

  • Write a comment I'll work on this if you would like to take this issue over.
    This way we get the chance to revise the description in case things have changed in the meantime, we might give you additional hints and we can assign the task to you, so that others do not start as well.
  • See Your first code contribution for guidelines.
  • Do not hesitate to ask questions here or to contact us via Atrium's slack channel if you need help
    (Invite yourself in case you do not have an account yet).
@Kushiro-C
Copy link
Contributor

I'll work on this

robstoll added a commit that referenced this issue Feb 19, 2022
Add samples tests for Fun0ExpectationSamples in infix syntax
@robstoll robstoll added this to the 0.18.0 milestone Feb 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants