Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ResultExpectationSamples also to api-infix #1157

Closed
3 tasks
robstoll opened this issue Jun 24, 2022 · 0 comments · Fixed by #1162
Closed
3 tasks

add ResultExpectationSamples also to api-infix #1157

robstoll opened this issue Jun 24, 2022 · 0 comments · Fixed by #1162
Assignees
Labels
Milestone

Comments

@robstoll
Copy link
Owner

Platform (all, jvm, js, android): all
Extension (none, kotlin 1.3): none

Code related feature

We also want to provide samples for the infix api

Following the things you need to do:

  • copy ResultExpectationSamples from fluent-api to api-infix, adjust imports ...api.fluent... to ...api.infix... and adjust the samples accordingly (always use the infix syntax, never the fluent).
    • take a look at existing Samples (e.g. ListFeatureExtractorSamples) in api-infix for how to format comments
  • check that the sample in the KDoc Intellij is showing looks good (ALT+Mouse-click on function name)

Your first contribution?

  • Write a comment I'll work on this if you would like to take this issue over.
    This way we get the chance to revise the description in case things have changed in the meantime, we might give you additional hints and we can assign the task to you, so that others do not start as well.
  • See Your first code contribution for guidelines.
  • Do not hesitate to ask questions here or to contact us via Atrium's slack channel if you need help
    (Invite yourself in case you do not have an account yet).
@robstoll robstoll self-assigned this Jun 28, 2022
@robstoll robstoll added this to the 0.19.0 milestone Jun 28, 2022
@robstoll robstoll linked a pull request Jun 28, 2022 that will close this issue
robstoll added a commit that referenced this issue Jun 29, 2022
…e-infix

add ResultExceptionSamples to infix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant