-
-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rewrite readme-examples/build.gradle to build.gradle.kts #1159
Comments
Hey, @robstoll I'll work on this :) |
So, to be specific I need to replace "build.gradle" with "build.gradle.kts" in the README.MD file right @robstoll ? |
No, your task is to rewrite https://github.com/robstoll/atrium/blob/main/misc/tools/readme-examples/build.gradle (i e. currently groovy based) to build.gradle.kts (Kotlin based) |
Well I haven't worked on groovy yet. Can you please provide some resource to get this work done? |
@Chandra-Sekhar-Bala I suggest you read https://kotlinlang.org/docs/multiplatform-add-dependencies.html and similar sites and compare groovy and Kotlin. If you are already familiar with gradle's Kotlin DSL then just rename build.gradle to build.gradle.kts and start fixing the errors |
@Chandra-Sekhar-Bala do you need help? |
I'll do this |
hello @robstoll I would like to work on this issue. |
hello @robstoll just needed a confirmation, you basically want is that to change the extension of the file and solve the errors. |
@DakshSuryavanshi you got it right. solving errors and migrate from groovy to kotlin is the same in this case. I don't think you need to read a lot of groovy stuff. Change the file extension and see what errors remain, the IDE will help you as well. And in case you are stuck, there are other build.gradle.kts in this project which have already been migrated |
@DakshSuryavanshi are you still working on that? If not, I can take it |
@jakubriegel IMO you can start with this, @DakshSuryavanshi can still try to come up with a PR on their own for learning purposes |
Cool 🚀 I'll make a PR in 2-3 days |
…es-build-gradle-build-gradle-kts rewrite readme-examples/build.gradle to build.gradle.kts
Platform (all, jvm, js): all
Extension (none, kotlin 1.3): none
Code related feature
Would be nicer to have the build file in Kotlin instead of groovy
Your first contribution?
I'll work on this
if you would like to take this issue over.This way we get the chance to revise the description in case things have changed in the meantime, we might give you additional hints and we can assign the task to you, so that others do not start as well.
(Invite yourself in case you do not have an account yet).
The text was updated successfully, but these errors were encountered: