Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rewrite readme-examples/build.gradle to build.gradle.kts #1159

Closed
robstoll opened this issue Jun 27, 2022 · 13 comments · Fixed by #1232
Closed

rewrite readme-examples/build.gradle to build.gradle.kts #1159

robstoll opened this issue Jun 27, 2022 · 13 comments · Fixed by #1232
Assignees
Milestone

Comments

@robstoll
Copy link
Owner

robstoll commented Jun 27, 2022

Platform (all, jvm, js): all
Extension (none, kotlin 1.3): none

Code related feature

Would be nicer to have the build file in Kotlin instead of groovy

Your first contribution?

  • Write a comment I'll work on this if you would like to take this issue over.
    This way we get the chance to revise the description in case things have changed in the meantime, we might give you additional hints and we can assign the task to you, so that others do not start as well.
  • See Your first code contribution for guidelines.
  • Do not hesitate to ask questions here or to contact us via Atrium's slack channel if you need help
    (Invite yourself in case you do not have an account yet).
@Chandra-Sekhar-Bala
Copy link

Hey, @robstoll I'll work on this :)

@Chandra-Sekhar-Bala
Copy link

So, to be specific I need to replace "build.gradle" with "build.gradle.kts" in the README.MD file right @robstoll ?

@robstoll
Copy link
Owner Author

robstoll commented Jul 2, 2022

No, your task is to rewrite https://github.com/robstoll/atrium/blob/main/misc/tools/readme-examples/build.gradle (i e. currently groovy based) to build.gradle.kts (Kotlin based)

@Chandra-Sekhar-Bala
Copy link

Well I haven't worked on groovy yet. Can you please provide some resource to get this work done?

@robstoll
Copy link
Owner Author

robstoll commented Jul 3, 2022

@Chandra-Sekhar-Bala I suggest you read https://kotlinlang.org/docs/multiplatform-add-dependencies.html and similar sites and compare groovy and Kotlin. If you are already familiar with gradle's Kotlin DSL then just rename build.gradle to build.gradle.kts and start fixing the errors

@robstoll
Copy link
Owner Author

@Chandra-Sekhar-Bala do you need help?

@kaustubhumbarkar17
Copy link

I'll do this

@DakshSuryavanshi
Copy link

DakshSuryavanshi commented Oct 5, 2022

hello @robstoll I would like to work on this issue.

@DakshSuryavanshi
Copy link

DakshSuryavanshi commented Oct 8, 2022

hello @robstoll just needed a confirmation, you basically want is that to change the extension of the file and solve the errors.
and finally convert groovy to kotlin.
Also i'm a bit new to groovy but well versed with kotlin so I'm really sorry for taking a bit longer than usual, i'll go through the resources given by you in the conversations above, hope those will be enough to know the basics.

@robstoll
Copy link
Owner Author

robstoll commented Oct 9, 2022

@DakshSuryavanshi you got it right. solving errors and migrate from groovy to kotlin is the same in this case. I don't think you need to read a lot of groovy stuff. Change the file extension and see what errors remain, the IDE will help you as well. And in case you are stuck, there are other build.gradle.kts in this project which have already been migrated

@jakubriegel
Copy link
Collaborator

@DakshSuryavanshi are you still working on that? If not, I can take it

@robstoll
Copy link
Owner Author

@jakubriegel IMO you can start with this, @DakshSuryavanshi can still try to come up with a PR on their own for learning purposes

@jakubriegel
Copy link
Collaborator

Cool 🚀 I'll make a PR in 2-3 days

@robstoll robstoll linked a pull request Oct 21, 2022 that will close this issue
robstoll added a commit that referenced this issue Oct 21, 2022
…es-build-gradle-build-gradle-kts

rewrite readme-examples/build.gradle to build.gradle.kts
@robstoll robstoll added this to the 0.19.0 milestone Oct 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants