Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

samples for CharSequence.toContain...value #1520

Closed
1 of 4 tasks
robstoll opened this issue Aug 22, 2023 · 1 comment · Fixed by #1532
Closed
1 of 4 tasks

samples for CharSequence.toContain...value #1520

robstoll opened this issue Aug 22, 2023 · 1 comment · Fixed by #1532
Assignees
Labels
Milestone

Comments

@robstoll
Copy link
Owner

robstoll commented Aug 22, 2023

Code related feature

Following the things you need to do:

api-fluent

  • add a value method in CharSequenceToContainCreatorsSamples for toContain....value(...) => already done
  • add a valueIgnoringCase method in CharSequenceToContainCreatorsSamples toContain.ignoringCase.value(...)
  • add a valueIgnoringCaseWithChecker method in CharSequenceToContainCreatorsSamples for toContain.ignoringCase...value(...)
  • link in the KDoc of the corresponding functions in charSequenceToContainCreators.kt to the sample via @sample (see function value in this file)

Your first contribution?

  • Write a comment I'll work on this if you would like to take this issue over.
    This way we get the chance to revise the description in case things have changed in the meantime, we might give you additional hints and we can assign the task to you, so that others do not start as well.
  • See Your first code contribution for guidelines.
  • Do not hesitate to ask questions here or to contact us via Atrium's slack channel if you need help
    (Invite yourself in case you do not have an account yet).
@Nikos-Tsiougranas
Copy link
Contributor

I will work on this!

Nikos-Tsiougranas added a commit to Nikos-Tsiougranas/atrium that referenced this issue Aug 29, 2023
Nikos-Tsiougranas added a commit to Nikos-Tsiougranas/atrium that referenced this issue Aug 29, 2023
Nikos-Tsiougranas added a commit to Nikos-Tsiougranas/atrium that referenced this issue Aug 29, 2023
@robstoll robstoll added this to the 1.1.0 milestone Aug 30, 2023
@robstoll robstoll linked a pull request Aug 30, 2023 that will close this issue
Nikos-Tsiougranas added a commit to Nikos-Tsiougranas/atrium that referenced this issue Aug 30, 2023
Nikos-Tsiougranas added a commit to Nikos-Tsiougranas/atrium that referenced this issue Aug 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants