-
-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Any.isNoneOf/isNotIn #180
Comments
I'll work on this. |
Hi, is someone working on this, else I will take over |
@DeMack, are you working on this? Else, I will start |
@DeMack do you need help? un-assining you so that others can take over until I get a response |
I'll work on this. |
@gawarz let me know in case you need help |
@gawarz unassigning you so that others can take over. Just leave a comment here in case you still work on it and I assign you again. |
I'll work on this |
@Jak-Sidious I just updated the description |
@Jak-Sidious un-assigning you so that others can take over |
I'll work on this |
Hello. I won't be able to finish this issue. please unasign me |
@robstoll can I work on this? |
Add Any.isNoneOf and Any.isNotIn assertions
Add Any.isNoneOf and Any.isNotIn assertions
Platform (jvm, jdk8, js, android): all
Code related feature
However, reporting should not state multiple
not to be
(in case of a Reporter which shows all assertions) but reflect the intended grouping.For instance:
should result in
As we can see from the example, we don't have to check for unique values, that's the responsibility of the developer. Moreover, we want fail-fast behaviour (thus we don't see the second
1
in reporting).Following the things you need to do:
atrium-logic
isNotIn
which expects aList<T>
(see existing functions as a guideline)assertionBuilder.list..
IS_NONE_OF("is none of")
to DescriptionAnyAssertion for en_GBIS_NONE_OF("ist nicht")
to DescriptionAnyAssertion for de_CH=> use it for
withDescriptionAndEmptyRepresentation
List<T>
to anassertionBuilder.representationOnly
(similar to /domain/robstoll-lib/atrium-domain-robstoll-lib-common/src/main/kotlin/ch/tutteli/atrium/domain/robstoll/lib/creating/iterable/contains/creators/InAnyOrderOnlyAssertionCreator.kt => createExplanatoryGroupForMismatchesEtc) and use them forwithAssertions
api-fluent-en_GB
isNoneOf
with signature(T, vararg T)
(see mapAssertions.kt -> contains as a guideline)@since 0.9.0
to KDOCisNotIn
with signatureIterable<T>
require
that theIterable.iterator.hasNext()
@since 0.9.0
to KDOCYour first contribution?
I'll work on this
if you would like to take this issue over.This way we get the chance to revise the description in case things have changed in the meantime,
we might give you additional hints and we can assign the task to you, so that others do not start as well.
(Invite yourself in case you do not have an account yet).
The text was updated successfully, but these errors were encountered: