Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

verify if KT-23178 (isInstace in JS) is really fixed #400

Closed
2 tasks
robstoll opened this issue Mar 21, 2020 · 1 comment · Fixed by #569
Closed
2 tasks

verify if KT-23178 (isInstace in JS) is really fixed #400

robstoll opened this issue Mar 21, 2020 · 1 comment · Fixed by #569
Assignees
Milestone

Comments

@robstoll
Copy link
Owner

Platform (jvm, js, android): js
Extension (none, kotlin 1.3, jdk8): none

Code related feature

We have currently a workaround implemented for

equals in KClass in JS not symmetric. Not working isInstance
https://youtrack.jetbrains.com/issue/KT-23178

The workaround made sure that casting in JS works as expected. JetBrains claims to have fixed this issue. We would like to be sure that this is really the case.
We should have implemented corresponding regression tests and there the things you need to do are:

  • rewrite core/api/atrium-core-api-js/src/main/kotlin/ch/tutteli/atrium/core/polyfills/kClassExtensions.kt according to the explanation given in the TODO
  • run the KClassCastTest via gradle gr :atrium-core-api-js:test and verify that it is still green after your change.

Your first contribution?

  • Write a comment I'll work on this if you would like to take this issue over.
    This way we get the chance to revise the description in case things have changed in the meantime, we might give you additional hints and we can assign the task to you, so that others do not start as well.
  • See Your first code contribution for guidelines.
  • Do not hesitate to ask questions here or to contact us via Atrium's slack channel if you need help
    (Invite yourself in case you do not have an account yet).
@robstoll robstoll changed the title verify if KT-23178 was really fixed verify if KT-23178 (isInstace in JS was buggy) is really fixed Mar 21, 2020
@robstoll robstoll changed the title verify if KT-23178 (isInstace in JS was buggy) is really fixed verify if KT-23178 (isInstace in JS) is really fixed Mar 21, 2020
@Valefant
Copy link
Collaborator

Valefant commented Sep 1, 2020

I would like to take this one

robstoll added a commit that referenced this issue Sep 2, 2020
Remove unnecessary check because isInstance now does work as expected
@robstoll robstoll added this to the 0.14.0 milestone Sep 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants