You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The workaround made sure that casting in JS works as expected. JetBrains claims to have fixed this issue. We would like to be sure that this is really the case.
We should have implemented corresponding regression tests and there the things you need to do are:
rewrite core/api/atrium-core-api-js/src/main/kotlin/ch/tutteli/atrium/core/polyfills/kClassExtensions.kt according to the explanation given in the TODO
run the KClassCastTest via gradle gr :atrium-core-api-js:test and verify that it is still green after your change.
Your first contribution?
Write a comment I'll work on this if you would like to take this issue over.
This way we get the chance to revise the description in case things have changed in the meantime, we might give you additional hints and we can assign the task to you, so that others do not start as well.
Do not hesitate to ask questions here or to contact us via Atrium's slack channel if you need help
(Invite yourself in case you do not have an account yet).
The text was updated successfully, but these errors were encountered:
robstoll
changed the title
verify if KT-23178 was really fixed
verify if KT-23178 (isInstace in JS was buggy) is really fixed
Mar 21, 2020
robstoll
changed the title
verify if KT-23178 (isInstace in JS was buggy) is really fixed
verify if KT-23178 (isInstace in JS) is really fixed
Mar 21, 2020
Platform (jvm, js, android): js
Extension (none, kotlin 1.3, jdk8): none
Code related feature
We have currently a workaround implemented for
The workaround made sure that casting in JS works as expected. JetBrains claims to have fixed this issue. We would like to be sure that this is really the case.
We should have implemented corresponding regression tests and there the things you need to do are:
gr :atrium-core-api-js:test
and verify that it is still green after your change.Your first contribution?
I'll work on this
if you would like to take this issue over.This way we get the chance to revise the description in case things have changed in the meantime, we might give you additional hints and we can assign the task to you, so that others do not start as well.
(Invite yourself in case you do not have an account yet).
The text was updated successfully, but these errors were encountered: