-
-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Limit representation to 10'000 characters #409
Comments
I'll work on this |
@jordi-farre Let me know in case you need help. |
@jordi-farre un-assigning you so that others can take over |
Could you help me by making hint for me. where should i make changes if i take this issue? |
@Gugatke In DetailedObjectFormatter where toString will be called (explicitly or implicitly). |
You can assign me for this one 👍 |
robstoll
added a commit
that referenced
this issue
Sep 1, 2020
Limit the text to represent calling DetailedObjectFormatter#format
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Platform (jvm, js, android): all
Extension (none, kotlin 1.3, jdk8): none
Code related feature
Currently we don't define a limit for the representation. In case of e.g. file content this can fill the output drastically and depending on the CI cause the job to crash, i e. invoking a fail fast even though we don't want. Thus define a maximum in DetailedObjectFormatter of 10'000. I think this number should be reasonably big enough without crashing builds.
Your first contribution?
I'll work on this
if you would like to take this issue over.This way we get the chance to revise the description in case things have changed in the meantime, we might give you additional hints and we can assign the task to you, so that others do not start as well.
(Invite yourself in case you do not have an account yet).
The text was updated successfully, but these errors were encountered: