Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit representation to 10'000 characters #409

Closed
robstoll opened this issue Mar 23, 2020 · 6 comments · Fixed by #566
Closed

Limit representation to 10'000 characters #409

robstoll opened this issue Mar 23, 2020 · 6 comments · Fixed by #566
Assignees
Milestone

Comments

@robstoll
Copy link
Owner

Platform (jvm, js, android): all
Extension (none, kotlin 1.3, jdk8): none

Code related feature

Currently we don't define a limit for the representation. In case of e.g. file content this can fill the output drastically and depending on the CI cause the job to crash, i e. invoking a fail fast even though we don't want. Thus define a maximum in DetailedObjectFormatter of 10'000. I think this number should be reasonably big enough without crashing builds.

Your first contribution?

  • Write a comment I'll work on this if you would like to take this issue over.
    This way we get the chance to revise the description in case things have changed in the meantime, we might give you additional hints and we can assign the task to you, so that others do not start as well.
  • See Your first code contribution for guidelines.
  • Do not hesitate to ask questions here or to contact us via Atrium's slack channel if you need help
    (Invite yourself in case you do not have an account yet).
@jordi-farre
Copy link

I'll work on this

@robstoll
Copy link
Owner Author

robstoll commented May 6, 2020

@jordi-farre Let me know in case you need help.

@robstoll
Copy link
Owner Author

@jordi-farre un-assigning you so that others can take over

@gugatkesheladze
Copy link

Could you help me by making hint for me. where should i make changes if i take this issue?

@robstoll
Copy link
Owner Author

@Gugatke In DetailedObjectFormatter where toString will be called (explicitly or implicitly).

@Valefant
Copy link
Collaborator

Valefant commented Sep 1, 2020

You can assign me for this one 👍

robstoll added a commit that referenced this issue Sep 1, 2020
Limit the text to represent calling DetailedObjectFormatter#format
@robstoll robstoll added this to the 0.14.0 milestone Sep 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants